Chart editor - Set playspeed after variation load #4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size: small
AbnormalPoof
added
type: minor bug
Hundrec
suggested changes
Feb 27, 2025
Hundrec
added
status: needs revision
Lasercar
force-pushed
the
chart-editor-set-play-speed-after-variation-load
branch
from
ae43086 to
8e8e7f1
Compare
Whoops, that's because I was dumb and didn't notice that I put the pitch changes in the audioInstTrack.onComplete function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Fixes #3041
Briefly describe the issue(s) fixed.
When a variation is loaded (or an audiotrack is reloaded), the new audiotracks don't have their playback speed set.
This PR fixes that, by doing after they're loaded.
Include any relevant screenshots or videos.